Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

parity: hide legacy options from cli --help #8967

Merged
merged 3 commits into from Jun 25, 2018
Merged

parity: hide legacy options from cli --help #8967

merged 3 commits into from Jun 25, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Jun 24, 2018

ref #2913

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M2-config 📂 Chain specifications and node configurations. labels Jun 24, 2018
@5chdn 5chdn added this to the 1.12 milestone Jun 24, 2018
@5chdn 5chdn added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Jun 24, 2018
@jimpo
Copy link
Contributor

jimpo commented Jun 24, 2018

Looks fine. Maybe worth adding a verbose: bool param to print_help and displaying legacy options if it is true? (as per discussion in #2913)

@5chdn
Copy link
Contributor Author

5chdn commented Jun 24, 2018

I'd like to give the --verbose option more love. For now, I would like to just get rid of the legacy options.

Initially, the --verbose idea was to actually deliver some background information. This PR is rather unrelated to #2913 except for the point that I raised this in the discussion.

@ascjones ascjones added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 25, 2018
@5chdn 5chdn merged commit edd90f1 into master Jun 25, 2018
@5chdn 5chdn deleted the a5-cli-legacy branch June 25, 2018 08:19
dvdplm added a commit that referenced this pull request Jun 25, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
37685ad 
* master:
  parity: hide legacy options from cli --help (#8967)
ordian added a commit to ordian/parity that referenced this pull request Jun 27, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
7617ced 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  parity: omit redundant last imported block number in light sync informant (openethereum#8962)
  Disable hardware-wallets on platforms that don't support `libusb` (openethereum#8464)
  Bump error-chain and quick_error versions (openethereum#8972)
  EVM benchmark utilities (openethereum#8944)
  parity: hide legacy options from cli --help (openethereum#8967)
  scripts: fix docker build tag on latest using master (openethereum#8952)
  Add type for passwords. (openethereum#8920)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@5chdn @jimpo @dvdplm @ascjones