This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Preserve the current abort behavior #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
|
Realized this doesn't need to be patched to stable or beta. We used a different method to fix CI build there: 4c3410e (but as it "hides" a crate in the workspace, we probably cannot take that approach on master.) |
debris
approved these changes
Jun 27, 2018
debris
added
A8-looksgood 🦄
ordian
approved these changes
Jun 27, 2018
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jul 9, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: parity: fix db path when migrating to blooms db (openethereum#8975) Preserve the current abort behavior (openethereum#8995) Improve should_replace on NonceAndGasPrice (openethereum#8980) Tentative fix for missing dependency error (openethereum#8973)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While removing panic=abort fixed the build, another issue is that our process is currently expected to be aborted if any of the threads fail. So this adds explicit process abort at the end of the panic hook.