Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scripts for android and related doc #708

Merged
merged 7 commits into from Jan 13, 2021
Merged

fix: scripts for android and related doc #708

merged 7 commits into from Jan 13, 2021

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Jan 10, 2021

closes #707

@Tbaut Tbaut mentioned this pull request Jan 10, 2021
@Tbaut Tbaut changed the title Fix scripts for android and related doc Fix: scripts for android and related doc Jan 10, 2021
@Tbaut Tbaut changed the title Fix: scripts for android and related doc fix: scripts for android and related doc Jan 10, 2021
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except it needs an explanation what yarn install:ios does.

docs/wiki/Building-And-Publishing.md Outdated Show resolved Hide resolved
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
@Tbaut Tbaut requested a review from TriplEight January 12, 2021 14:23
TriplEight
TriplEight previously approved these changes Jan 12, 2021
@Tbaut
Copy link
Contributor Author

Tbaut commented Jan 12, 2021

Not sure why this E2E test is hanging for hours and timing out... It failed in the last merge to master. I don't think it's related to this PR, but we should take a look.

@Tbaut Tbaut merged commit 8b540ab into master Jan 13, 2021
@Tbaut Tbaut deleted the tbaut-doc branch January 13, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build on linux
3 participants