Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Fixed panic when header is verifying for (Verifying | Stored) block #99

Merged

Conversation

svyatonik
Copy link
Contributor

closes #97

This has been introduced recently, when headers verification has been moved to the separate thread. In some (rare) cases, we may have end up in situation when (at the same time) block' header is verifying in light_verification_thread and the block itself is verified in the heavy_verification_thread. Once both verifications are completed, block is stored in DB, but it is marked as Scheduled by the sync.

@svyatonik svyatonik merged commit 00420b2 into master Apr 24, 2019
@svyatonik svyatonik deleted the fix_known_blocks_are_ignored_in_headers_verification_success branch April 24, 2019 10:22
@tearodactyl
Copy link

Great to see that you found an interaction between threads, those are notoriously hard to catch.
May I suggest that you start tagging your 'master' to introduce some baselines, even if you are not ready to bake a 0.0.1 release.
That way interested parties, like myself will be able to pull in commits, re-test and report the outcomes in an organized fashion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification Panicked
3 participants