Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Health check API endpoint #4801

Closed
tomusdrw opened this issue Mar 7, 2017 · 5 comments
Closed

Health check API endpoint #4801

tomusdrw opened this issue Mar 7, 2017 · 5 comments
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@tomusdrw
Copy link
Collaborator

tomusdrw commented Mar 7, 2017

curl -v http://localhost:8080/api/status should return basic health of the node: number of peers, syncing status

@tomusdrw tomusdrw added F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. labels Mar 7, 2017
@adrianbrink
Copy link

Is there a tag for low hanging fruit or easy? This is probably a good intro. Also, in which crate do all the end points live?

@tomusdrw tomusdrw added the Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. label Mar 8, 2017
@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Mar 8, 2017

Hi @adrianbrink! I've tagged this as Q2-easy.

The right place to put this would be here:
https://github.com/ethcore/parity/blob/81b57a57c713d9bc67efd8950ef1c94e0a0238a5/dapps/src/api/api.rs#L147-L152

It will be required to push through additional dependencies like SyncStatus and Client to get peers and some other stats (like latest block number perhaps).

@adrianbrink
Copy link

Awesome. I'll send a PR by Sunday. :-)

@adrianbrink
Copy link

@tomusdrw sorry, I'll send it tomorrow. Didn't have enough time today.

@andresilva
Copy link
Contributor

I think this can be closed now.

@arkpar arkpar closed this as completed Jul 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

4 participants