This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
eth price in cli should not be displayed for private chains #6228
Labels
F3-annoyance 💩
The client behaves within expectations, however this “expected behaviour” itself is at issue.
M2-config 📂
Chain specifications and node configurations.
P7-nicetohave 🐕
Issue is worth doing eventually.
Q2-easy 💃
Can be fixed by copy and pasting from StackOverflow.
Milestone
Comments
debris
added
F3-annoyance 💩
|
Actually it's valid only for |
|
Maybe solve it by |
|
+1 for more chain abstraction in the client via config, this could be solved too: #4123 |
Closed
5chdn
added
M2-config 📂
nicolasochem
pushed a commit
to nicolasochem/parity
that referenced
this issue
Oct 23, 2017
Current behaviour: When the client is started with defaults, the miner's gas calibrator periodically queries the price of ether in usd and uses it to adjust the wei_per_gas variable, displaying an info message in the cli each time calibration happens. This behaviour is also present when running on a non-foundation chain such as ethereum classic. When the client is started with --min-gas-price N, this does not happen as GasPricer::Fixed is instanciated instead of GasPricer::Calibrated. Solution: For non-foundation chain, hard-code a default gas price (wei_per_gas, currently 40M wei) in the spec json file. When the wei_per_gas parameter is found and greater than zero, force the miner to start with GasPricer::Fixed, so the calibrator does not run at all.
nicolasochem
pushed a commit
to nicolasochem/parity
that referenced
this issue
Oct 23, 2017
Current behaviour: When the client is started with defaults, the miner's gas calibrator periodically queries the price of ether in usd and uses it to adjust the wei_per_gas variable, displaying an info message in the cli each time calibration happens. This behaviour is also present when running on a non-foundation chain such as ethereum classic. When the client is started with --min-gas-price N, this does not happen as GasPricer::Fixed is instanciated instead of GasPricer::Calibrated. Solution: For non-foundation chain, hard-code a default gas price (wei_per_gas, currently 40M wei) in the spec json file. When the wei_per_gas parameter is found and greater than zero, force the miner to start with GasPricer::Fixed, so the calibrator does not run at all.
nicolasochem
pushed a commit
to nicolasochem/parity
that referenced
this issue
Oct 24, 2017
Current behaviour: When the client is started with defaults, the miner's gas calibrator periodically queries the price of ether in usd and uses it to adjust the wei_per_gas variable, displaying an info message in the cli each time calibration happens. The info message mentions the price of ETH. When started with the --min-gas-price option, the calibrator is inactive and the price is not displayed. Problem: When running on an alternate chain such as ethereum classic, the info message mentioning the ETH price is present, unless the --min-gas-price option is used. Solution: if chain != foundation and --min-gas-price is not set, don't use GasPricerConfig::Calibrated as default but rather fix the minimum gas price to zero.
nicolasochem
pushed a commit
to nicolasochem/parity
that referenced
this issue
Oct 24, 2017
Current behaviour: When the client is started with defaults, the miner's gas calibrator periodically queries the price of ether in usd and uses it to adjust the wei_per_gas variable, displaying an info message in the cli each time calibration happens. The info message mentions the price of ETH. When started with the --min-gas-price option, the calibrator is inactive and the price is not displayed. Problem: When running on an alternate chain such as ethereum classic, the info message mentioning the ETH price is present, unless the --min-gas-price option is used. Solution: if chain != foundation and --min-gas-price is not set, don't use GasPricerConfig::Calibrated as default but rather fix the minimum gas price to zero.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: