This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix #6209 - introduce standalone dir crate #7383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolasochem
commented
Dec 26, 2017
nicolasochem
commented
- created the dir crate in util
- moved code from ethstore/src/dir/paths.rs to dir crate
- rename dir module in ethstore to accounts_dir to distinguish it from the dir crate
- rebase and include code review changes
|
It looks like @nicolasochem signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
added 3 commits
December 26, 2017 00:54
* created the dir crate in util * moved code from ethstore/src/dir/paths.rs to dir crate * rename dir module in ethstore to accounts_dir to distinguish it from the dir crate * changes after @tomusdrw on openethereum#6952
nicolasochem
force-pushed
the
dircrate2
branch
from
d030320
to
a8001ab
Compare
|
@tomusdrw please review |
tomusdrw
approved these changes
Dec 27, 2017
util/dir/src/lib.rs
Outdated
|
|
||
| mod platform { | ||
| use std::path::PathBuf; | ||
| #[cfg(target_os = "macos")] |
There was a problem hiding this comment.
What I mean with platform module is:
// re-export
pub use platform::*;
#[cfg(target_os = "macos")]
mod platform {
pub const CACHE_PATH: &'static str = "$BASE/cache";
pub fn parity_base() -> PathBuf { ... }
}
#[cfg(windows)]
mod platform {
pub const CACHE_PATH: &'static str = "$LOCAL/cache";
pub fn parity_base() -> PathBuf { ... }
}So that you don't need to repeat those #[cfg( statements for all methods, since it might be a bit confusing to understand what is exposed where.
tomusdrw
added
A6-mustntgrumble 💦
|
@tomusdrw fixed, please check again |
tomusdrw
reviewed
Dec 27, 2017
util/dir/src/lib.rs
Outdated
| @@ -28,6 +28,8 @@ use bigint::hash::{H64, H256}; | |||
| use journaldb::Algorithm; | |||
| use helpers::{replace_home, replace_home_and_local}; | |||
| use app_dirs::{AppInfo, get_app_root, AppDataType}; | |||
| // re-export platform-specific functions | |||
| use platform::*; | |||
|
|
|||
| #[cfg(target_os = "macos")] const AUTHOR: &'static str = "Parity"; | |||
| #[cfg(target_os = "macos")] const PRODUCT: &'static str = "io.parity.ethereum"; | |||
There was a problem hiding this comment.
Sorry to grumble again, would you mind moving this constants to platform as well?
|
@tomusdrw please check again |
svyatonik
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
tomusdrw
approved these changes
Dec 28, 2017
|
Looks perfect! 👍 |
debris
added a commit
that referenced
this pull request
Dec 29, 2017
standalone dir crate, replaces #7383
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.