Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Parity Stable branch does not compile on OSX #8315

Closed
mudlee opened this issue Apr 5, 2018 · 6 comments
Closed

Parity Stable branch does not compile on OSX #8315

mudlee opened this issue Apr 5, 2018 · 6 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M0-build 🏗 Building and build system.
Milestone

Comments

@mudlee
Copy link

mudlee commented Apr 5, 2018

Hi all. Parity stable branch does not compile for me on OSX with the newest (1.25.0) rust.

I'm running:

  • Which Parity version?: stable branch as a date of 5th April 2018
  • Which operating system?: MacOS
  • How installed?: from source

See the output here: https://gist.github.com/mudlee/829364a63a6acbd359705cd2c11a7f8f

@niklasad1
Copy link
Collaborator

Hi, you are using an old version of app_dirs it should be version 1.2.1.

if you are running the latest version try:

$ cargo clean && cargo build

@mudlee
Copy link
Author

mudlee commented Apr 5, 2018

But... how should upgrade? The rust is the latest (installed today than rustup update), and I cloned out this repo today. The master compiles well, the stable does not.

@rphmeier rphmeier added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M0-build 🏗 Building and build system. labels Apr 5, 2018
@rphmeier
Copy link
Contributor

rphmeier commented Apr 5, 2018

Indeed. We would need to either release an update to our stable and beta branches, or you can build them using an old version of the rust compiler (new versions of rustc broke old versions of app_dirs)

@5chdn 5chdn added this to the Patch milestone Apr 5, 2018
@mudlee
Copy link
Author

mudlee commented Apr 6, 2018

I see, please notify me in this issue if its been patched. thx!

@niklasad1
Copy link
Collaborator

@mudlee Should be fixed now

@mudlee
Copy link
Author

mudlee commented Apr 10, 2018

Yes it does build now, thx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M0-build 🏗 Building and build system.
Projects
None yet
Development

No branches or pull requests

4 participants