Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Tidy up CLI options and make JSONRPC & webapps on by default. #1045

Merged
merged 2 commits into from May 4, 2016
Merged

Tidy up CLI options and make JSONRPC & webapps on by default. #1045

merged 2 commits into from May 4, 2016

Conversation

gavofyork
Copy link
Contributor

No description provided.

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label May 4, 2016
@NikVolf NikVolf added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 4, 2016
@NikVolf
Copy link
Contributor

NikVolf commented May 4, 2016 •
edited

personal api exposed via http is very unsecure
no client does it by default
(maybe warning should be given when remote connections are allowed and personal api is exposed at the same time)

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. A0-pleasereview 🤓 Pull request needs code review. labels May 4, 2016
@gavofyork gavofyork merged commit 0d50792 into master May 4, 2016
@gavofyork gavofyork deleted the clidefs branch May 4, 2016 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gavofyork @NikVolf