Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

pretty print trace error #1098

Merged
merged 9 commits into from May 19, 2016
Merged

pretty print trace error #1098

merged 9 commits into from May 19, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented May 18, 2016

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label May 18, 2016
@debris debris changed the title propagate trace error to the top pretty print trace error May 18, 2016

const RESYNC_ERR: &'static str =
"Your current parity installation has synced without transaction tracing. To use
Parity with transaction tracing, you'll need to resync with tracing. To do this, remove or move away your current
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird line breaking?

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 18, 2016
@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels May 18, 2016
@arkpar arkpar added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 19, 2016
@debris
Copy link
Collaborator Author

debris commented May 19, 2016

conflicts resolved

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels May 19, 2016
@arkpar
Copy link
Collaborator

arkpar commented May 19, 2016

does not compile

@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A8-looksgood 🦄 Pull request is reviewed well. labels May 19, 2016
@debris
Copy link
Collaborator Author

debris commented May 19, 2016

I merged incorrectly (do not know how it happened). Should be fine now. I will remove gotiisues flag once travis is green

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels May 19, 2016
@debris debris merged commit 8521559 into master May 19, 2016
@debris debris deleted the trace_err branch June 20, 2016 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants