This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Have die_with_error use fmt::Display rather than Debug
#1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| impl<T: fmt::Debug + fmt::Display> fmt::Display for OutOfBounds<T> { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| let msg = match (self.min.as_ref(), self.max.as_ref()) { | ||
| (Some(min), Some(max)) => { |
There was a problem hiding this comment.
all single-statement arms - no need for {s
gavofyork
added
the
A6-mustntgrumble 💦
| @@ -132,6 +258,24 @@ pub enum ImportError { | |||
| KnownBad, | |||
| } | |||
|
|
|||
| impl fmt::Display for ImportError { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | |||
| let msg = match self { | |||
There was a problem hiding this comment.
|
I am working on addressing the style concerns at the moment. |
| UtilError::FromHex(ref err) => f.write_fmt(format_args!("{}", err)), | ||
| UtilError::BaseData(ref err) => f.write_fmt(format_args!("{}", err)), | ||
| UtilError::Network(ref err) => f.write_fmt(format_args!("{}", err)), | ||
| UtilError::Decoder(ref err) => f.write_fmt(format_args!("{}", err)), |
There was a problem hiding this comment.
DecoderError has a Display impl which just forwards to its derived Debug impl. This can be rewritten as well.
arkpar
added
A0-pleasereview 🤓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @debris
Fixes #1099
Please look at the error messages I wrote for accuracy and refinement!