Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Exporting #1129

Merged
merged 3 commits into from May 24, 2016
Merged

Exporting #1129

merged 3 commits into from May 24, 2016

Conversation

gavofyork
Copy link
Contributor

No description provided.

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label May 23, 2016
n
} else if let Ok(h) = H256::from_str(s) {
client.block_number(BlockID::Hash(h)).unwrap_or_else(|| {
die!("Unknown block hash passed to --to parameter: {:?}", s);
Copy link
Collaborator

@tomusdrw tomusdrw May 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used for both --from and --toso the message might be misleading.

@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 24, 2016
@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels May 24, 2016
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 24, 2016
@arkpar arkpar merged commit f484beb into master May 24, 2016
@debris debris deleted the exporting branch June 20, 2016 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants