This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Sync fixes and tweaks #1164
Merged
Sync fixes and tweaks #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| peer.ask_time = time::precise_time_s(); | ||
| } | ||
| let mut peer = self.peers.get_mut(&peer_id).unwrap(); | ||
| peer.asking = asking; |
There was a problem hiding this comment.
Always set the asking status so that requested blocks would be unmarked as being downloaded on disconnect.
gavofyork
added
A8-looksgood 🦄
arkpar
added
A0-pleasereview 🤓
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
| @@ -159,7 +159,7 @@ fn propagate_hashes() { | |||
|
|
|||
| #[test] | |||
| fn propagate_blocks() { | |||
| let mut net = TestNet::new(2); | |||
| let mut net = TestNet::new(20); | |||
There was a problem hiding this comment.
shouldn't it also work for a small number of peers?
There was a problem hiding this comment.
Now the NewHashes message is sent out first, than NewBlock to some of the remaining peers. So this test requires more peers
NikVolf
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1159