Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fatdb integration with CLI #1464

Merged
merged 5 commits into from Jul 1, 2016
Merged

Fatdb integration with CLI #1464

merged 5 commits into from Jul 1, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Jun 27, 2016

based on #1452

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Jun 27, 2016
@@ -171,6 +171,7 @@ Footprint Options:
the entire system, overrides other cache and queue
options.
--db-cache-size MB Database cache size.
--fatdb Fat database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--fat-db

@gavofyork gavofyork removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jun 30, 2016
if let journaldb::Algorithm::Archive = client_config.pruning {
client_config.trie_spec = TrieSpec::Fat;
} else {
die!("Fatdb is supported only with pruning 'archive'.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the exact option user should use?
i.e.
rerun with --pruning=archive

@NikVolf NikVolf added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 1, 2016
@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Jul 1, 2016
@NikVolf NikVolf added A8-backport 🕸 Pull request is already reviewed well in another branch. A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A8-backport 🕸 Pull request is already reviewed well in another branch. labels Jul 1, 2016
@gavofyork gavofyork merged commit d8a4cca into master Jul 1, 2016
@gavofyork gavofyork deleted the fatdb_integration branch July 1, 2016 18:29
@debris debris mentioned this pull request Jul 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants