This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
Pull request needs code review.
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
labels
Jun 27, 2016
@@ -171,6 +171,7 @@ Footprint Options: | |||
the entire system, overrides other cache and queue | |||
options. | |||
--db-cache-size MB Database cache size. | |||
--fatdb Fat database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--fat-db
gavofyork
removed
the
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
label
Jun 30, 2016
if let journaldb::Algorithm::Archive = client_config.pruning { | ||
client_config.trie_spec = TrieSpec::Fat; | ||
} else { | ||
die!("Fatdb is supported only with pruning 'archive'.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the exact option user should use?
i.e.
rerun with --pruning=archive
NikVolf
added
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Jul 1, 2016
debris
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
labels
Jul 1, 2016
NikVolf
added
A8-backport 🕸
Pull request is already reviewed well in another branch.
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
A8-backport 🕸
Pull request is already reviewed well in another branch.
labels
Jul 1, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1452