Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

topbar dialog fix #1479

Merged
merged 2 commits into from Jun 29, 2016
Merged

topbar dialog fix #1479

merged 2 commits into from Jun 29, 2016

Conversation

goldylucks
Copy link
Contributor

@goldylucks goldylucks added the A0-pleasereview 🤓 Pull request needs code review. label Jun 28, 2016
@@ -23,7 +23,7 @@ ethcore-util = { path = "../util" }
parity-dapps = { git = "https://github.com/ethcore/parity-dapps-rs.git", version = "0.3" }
# List of apps
parity-dapps-status = { git = "https://github.com/ethcore/parity-dapps-status-rs.git", version = "0.5.0" }
parity-dapps-builtins = { git = "https://github.com/ethcore/parity-dapps-builtins-rs.git", version = "0.5.0" }
parity-dapps-builtins = { git = "https://github.com/goldylucks/parity-dapps-builtins-rs.git", version = "0.5.2" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to have this under the ethcore umbrella

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo restructuring will happen soon

@NikVolf NikVolf added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 28, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Jun 29, 2016
@tomusdrw
Copy link
Collaborator

@goldylucks Permissions to ethcore/parity-dapps-builtins-rs granted.

@gavofyork gavofyork added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jun 29, 2016
@gavofyork
Copy link
Contributor

will wait until it's in the ethcore repo...

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jun 29, 2016
@rphmeier
Copy link
Contributor

Moved into ethcore repo. I think this is also supposed to be in 1.2.1?

@gavofyork gavofyork modified the milestone: 1.2.1 Jun 29, 2016
@gavofyork gavofyork merged commit aec4130 into master Jun 29, 2016
@gavofyork gavofyork deleted the topbar-dialog-fix branch June 29, 2016 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants