This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Save block reference in the queue on notification #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A8-looksgood 🦄
| @@ -263,6 +263,9 @@ impl Miner { | |||
| let number = block.block().fields().header.number(); | |||
| let difficulty = *block.block().fields().header.difficulty(); | |||
| sealing_work.push(block); | |||
| if self.work_poster.is_some() { | |||
There was a problem hiding this comment.
Would have preferred to see it closer to the code that relies on it (i.e. the last line of the function).
Good enough for now, but perhaps add a comment saying what it's doing.
There was a problem hiding this comment.
Placed it there to avoid locking the sealing_work mutex again. Notification is done with the mutex released
gavofyork
added
A6-mustntgrumble 💦
|
Added a comment |
arkpar
added
A0-pleasereview 🤓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.