Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

serde is no longer util dependency #1534

Merged
merged 26 commits into from Jul 6, 2016
Merged

serde is no longer util dependency #1534

merged 26 commits into from Jul 6, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 4, 2016

based on #1474

changes:

  • serde is no longer util dependency
  • updated hyper version used by igd, now it's the same version as the one used by rpc
  • hash / uint serialization is moved to rpc module
  • Table and UsingQueue are now standalone libraries (but they remained a part of util)
  • reduced util compilation time 283.07s -> 250.67s (including all dependencies)

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Jul 4, 2016
@arkpar
Copy link
Collaborator

arkpar commented Jul 5, 2016

Too large to review in detail. Looks good in general

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 5, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Jul 5, 2016

based on #1474
@gavofyork can you re-review that?

@gavofyork gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jul 5, 2016
@gavofyork gavofyork merged commit bcb63bc into master Jul 6, 2016
@gavofyork gavofyork deleted the removing_todos branch July 6, 2016 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants