Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Attempt to fix blochchain/extras DBs sync #1538

Merged
merged 1 commit into from Jul 5, 2016
Merged

Attempt to fix blochchain/extras DBs sync #1538

merged 1 commit into from Jul 5, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Jul 4, 2016 •
edited

Fixes #1535

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Jul 4, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 4, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Jul 4, 2016

A lot of unwraps in this code -- better error messages would be helpful

@rphmeier rphmeier added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jul 4, 2016
@arkpar
Copy link
Collaborator Author

arkpar commented Jul 5, 2016 •
edited

unwrap for Result prints detailed error message.
Adding database error handling all over this file is outside the scope of this PR

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jul 5, 2016
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 5, 2016
@NikVolf NikVolf merged commit bbf20c3 into master Jul 5, 2016
@NikVolf NikVolf deleted the bc-restore branch July 5, 2016 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arkpar @rphmeier @debris @NikVolf