Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing deadlock in miner #1569

Merged
merged 2 commits into from Jul 8, 2016
Merged

Fixing deadlock in miner #1569

merged 2 commits into from Jul 8, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Jul 8, 2016

No description provided.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Jul 8, 2016
@debris
Copy link
Collaborator

debris commented Jul 8, 2016

Can you add some comment to the code, so the bug won't be (re)introduced by future changes?

@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Jul 8, 2016

Sure. I will also add some tests in (near) future.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 8, 2016
@gavofyork gavofyork merged commit eef9586 into master Jul 8, 2016
@gavofyork gavofyork deleted the deadlock-fix branch July 8, 2016 15:19
arkpar pushed a commit that referenced this pull request Jul 11, 2016
* Fixing deadlock in miner

* Adding more comments [ci skip]
arkpar pushed a commit that referenced this pull request Jul 11, 2016
* Fixing deadlock in miner
* Adding more comments [ci skip]
arkpar pushed a commit that referenced this pull request Jul 11, 2016
* Fixing deadlock in miner
* Adding more comments
gavofyork pushed a commit that referenced this pull request Jul 12, 2016
* Update sealing just once when  externally importing many blocks (#1541)

Fixes Issue #1372

* Fixing deadlock in miner (#1569)

* Fixing deadlock in miner
* Adding more comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants