This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Very basic EVM binary. #1574
Merged
Very basic EVM binary. #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A8-looksgood 🦄
| @@ -95,11 +95,17 @@ impl<'a> Finalize for Result<GasLeft<'a>> { | |||
| } | |||
| } | |||
|
|
|||
| /// Cost calculation type. For low-gas usage we calculate costs using usize instead of U256 | |||
There was a problem hiding this comment.
for 32-bit usize, this may lead to a consensus issue - u64 should be a lot safer.
There was a problem hiding this comment.
Why? If it doesn't fit in usize we fallback to U256 - it optimizes for u32 on 32-bit systems and for u64 for 64-bit ones.
Using optimized (whether it's u64 or u32) and non-optimized (u256) version should is not affecting consensus.
gavofyork
added
A6-mustntgrumble 💦
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.