Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Performance optimizations #1642

Merged
merged 6 commits into from Jul 17, 2016
Merged

Performance optimizations #1642

merged 6 commits into from Jul 17, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Jul 16, 2016

No description provided.

@arkpar arkpar added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jul 16, 2016
@coveralls
Copy link

coveralls commented Jul 16, 2016 •
edited

Coverage Status

Coverage increased (+0.09%) to 76.34% when pulling 5079523 on misc-perf into 5dba431 on master.

@coveralls
Copy link

coveralls commented Jul 16, 2016 •
edited

Coverage Status

Coverage increased (+0.08%) to 76.331% when pulling 0b72dd7 on misc-perf into 5dba431 on master.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 16, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 16, 2016
@coveralls
Copy link

coveralls commented Jul 16, 2016 •
edited

Coverage Status

Coverage increased (+0.04%) to 76.286% when pulling 0b72dd7 on misc-perf into 5dba431 on master.

gavofyork
gavofyork reviewed Jul 17, 2016
View reviewed changes
ethcore/src/account.rs
@@ -35,6 +35,8 @@ pub struct Account {
code_hash: Option<H256>,
// Code cache of the account.
code_cache: Bytes,
// Account is new or has been modified
dirty: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have Filth type for exactly this.

@gavofyork gavofyork merged commit 5ab18d1 into master Jul 17, 2016
@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jul 17, 2016
@arkpar arkpar deleted the misc-perf branch July 28, 2016 08:56
This was referenced Apr 27, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkpar @coveralls @gavofyork