Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Size for blocks #1668

Merged
merged 2 commits into from Jul 19, 2016
Merged

Size for blocks #1668

merged 2 commits into from Jul 19, 2016

Conversation

gavofyork
Copy link
Contributor

Closes #1655

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Jul 19, 2016
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 19, 2016
@coveralls
Copy link

coveralls commented Jul 19, 2016 •
edited

Coverage Status

Coverage increased (+0.007%) to 76.264% when pulling 011f351 on size-for-blocks into 3cc3dbe on master.

@arkpar arkpar merged commit 861c8d0 into master Jul 19, 2016
@slothbag
Copy link

This size field is causing issues for me in downstream RPC libraries. I believe they are expecting the size field to be hex encoded just like all the other fields. Geth also includes the size field as hex encoded.

If you like I can raise a separate issue for this.

@arkpar arkpar deleted the size-for-blocks branch October 3, 2016 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gavofyork @coveralls @slothbag @tomusdrw @arkpar