Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Collect consensus/null engines into a single module #1754

Merged
merged 3 commits into from Jul 28, 2016
Merged

Collect consensus/null engines into a single module #1754

merged 3 commits into from Jul 28, 2016

Conversation

keorn
Copy link

@keorn keorn commented Jul 28, 2016

Just moving code around.

@keorn keorn added the A0-pleasereview 🤓 Pull request needs code review. label Jul 28, 2016
@rphmeier
Copy link
Contributor

why not put the Engine trait into engines/mod.rs?

@rphmeier rphmeier added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 28, 2016
@rphmeier
Copy link
Contributor

LGTM other than grumble

@keorn
Copy link
Author

keorn commented Jul 28, 2016

Ok, wasnt sure.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Jul 28, 2016
@coveralls
Copy link

coveralls commented Jul 28, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 86.87% when pulling d71506e on engines-module into 3199576 on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 28, 2016
@coveralls
Copy link

coveralls commented Jul 28, 2016 •
edited

Coverage Status

Coverage increased (+0.09%) to 86.858% when pulling d71506e on engines-module into 3199576 on master.

@coveralls
Copy link

coveralls commented Jul 28, 2016 •
edited

Coverage Status

Coverage remained the same at 86.771% when pulling 81dec93 on engines-module into 3199576 on master.

@gavofyork gavofyork merged commit 11cb544 into master Jul 28, 2016
@gavofyork gavofyork deleted the engines-module branch July 28, 2016 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keorn @rphmeier @coveralls @gavofyork @arkpar