Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix state unsafety with a mostly-guaranteed handle #1755

Merged
merged 2 commits into from Jul 30, 2016
Merged

fix state unsafety with a mostly-guaranteed handle #1755

merged 2 commits into from Jul 30, 2016

Conversation

rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier added the A0-pleasereview 🤓 Pull request needs code review. label Jul 28, 2016
@coveralls
Copy link

coveralls commented Jul 28, 2016 •
edited

Coverage Status

Coverage decreased (-0.02%) to 86.754% when pulling 7daae1c on fix-state-unsafety into 3199576 on master.

@gavofyork
Copy link
Contributor

couldn't we just pass a lambda straight in to ensure_cached?

@coveralls
Copy link

coveralls commented Jul 29, 2016 •
edited

Coverage Status

Coverage increased (+0.02%) to 86.787% when pulling 56f7232 on fix-state-unsafety into 3199576 on master.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 30, 2016
@gavofyork gavofyork merged commit 53f1d7b into master Jul 30, 2016
@gavofyork gavofyork deleted the fix-state-unsafety branch July 30, 2016 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rphmeier @coveralls @gavofyork