Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Return storage as H256 from RPC. #1774

Merged
merged 2 commits into from Jul 30, 2016
Merged

Return storage as H256 from RPC. #1774

merged 2 commits into from Jul 30, 2016

Conversation

gavofyork
Copy link
Contributor

@gavofyork gavofyork commented Jul 30, 2016 •
edited

This change in the spec, following a (fairly sensible) geth bug and requested by a user.

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Jul 30, 2016
@coveralls
Copy link

coveralls commented Jul 30, 2016 •
edited

Coverage Status

Coverage decreased (-0.01%) to 86.839% when pulling 52e520f on h256-storage into 53f1d7b on master.

@gavofyork
Copy link
Contributor Author

gavofyork commented Jul 30, 2016 •
edited

timeout - ran ./test.sh locally and no problem.

@keorn keorn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 30, 2016
@keorn
Copy link

keorn commented Jul 30, 2016

restarted the tests just to make sure.

@gavofyork gavofyork merged commit b29329c into master Jul 30, 2016
@gavofyork gavofyork deleted the h256-storage branch July 30, 2016 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gavofyork @coveralls @keorn