Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Commit best block after closing transaction #1791

Merged
merged 1 commit into from Aug 1, 2016
Merged

Commit best block after closing transaction #1791

merged 1 commit into from Aug 1, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Aug 1, 2016 •
edited

commit applies best block only after db transaction have been committed.
closes #1785

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Aug 1, 2016
@coveralls
Copy link

coveralls commented Aug 1, 2016 •
edited

Coverage Status

Coverage increased (+0.03%) to 86.935% when pulling 0b93025 on best-block-apply into 4e72608 on master.

@tomusdrw
Copy link
Collaborator

tomusdrw commented Aug 1, 2016

Maybe we could have callback DBTransaction? Then everything could be done whenever DB is written?

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 1, 2016
@gavofyork gavofyork merged commit d891e80 into master Aug 1, 2016
@gavofyork gavofyork deleted the best-block-apply branch August 1, 2016 17:10
@gavofyork
Copy link
Contributor

will leave potential refactoring to later issue/PR since it's non-urgent, unlike this bug fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid State Root Error while importing new block
4 participants
@arkpar @coveralls @tomusdrw @gavofyork