This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing account naming #1810
Merged
Fixing account naming #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
the
A3-inprogress ⏳
|
would be good to more or lesss copy geth's format and document our decision on the wiki:
that said, we might leave out the nanoseconds. |
|
Ok, should we have a migration for old keys? Or is it only for newly created? |
|
only for newly created - should only require alteration of the |
tomusdrw
added
A0-pleasereview 🤓
|
Done. It required alterations of geth import logic as well (so that we don't duplicate account files). |
debris
added
A8-looksgood 🦄
| keyfile_path.push(format!("{}-{}.json", keyfile.id, timestamp)); | ||
| Some(keyfile_path) | ||
| let filename = account.filename.as_ref().cloned().unwrap_or_else(|| { | ||
| let timestamp = time::strftime("%Y-%m-%dT%H-%M-%S", &time::now_utc()).unwrap_or("???".to_owned()); |
There was a problem hiding this comment.
are ?s a valid component of file names on all platforms?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:is not valid part of filename on windowsFrom<KeyFile>implementation removed and replaced withSafeAccount::from_fileusage.I'm still doing some more tests to confirm that those issues are solved:
Closes #1808
Closes #1809