moved hash.rs to bigint library #1827

debris · 2016-08-03T16:08:23Z

in next pr, I will make ethkey/ethstore use bigint library

coveralls · 2016-08-03T16:46:28Z

Coverage decreased (-0.2%) to 86.929% when pulling e8c451a on move_hash into 40a304b on master.

tomusdrw · 2016-08-03T16:59:43Z

ethcore/src/client/client.rs

@@ -648,7 +648,7 @@ impl BlockChainClient for Client {
 			timestamp: view.timestamp(),
 			difficulty: view.difficulty(),
 			last_hashes: last_hashes,
-			gas_used: U256::zero(),
+			gas_used: Default::default(),


TBH I prefer more explicit approach in such cases (U256::default(), U256::from(0)), for me it just means less cognitive load.

Look at transaction_hash below especialy, It's quite difficult to understand what type is returned (it gets even more tricky when there is some more .maping on options/results/vectors done).

But it's just an opinion :) I'm good with the changes 👍

yes i think U256::zero() is much more preferred even
we deal with numbers here, not with some objects/classes

coveralls · 2016-08-04T07:20:30Z

Coverage decreased (-0.1%) to 86.488% when pulling 4051524 on move_hash into 7093651 on master.

tomusdrw · 2016-08-04T07:32:14Z

util/bigint/src/hash.rs

 	fn shift_bloomed() {
-		use sha3::Hashable;
+		//use sha3::Hashable;


What happened here? Ignored and commented out?

I should have mentioned that in PR description. It's commented out and will be moved out of hash.rs. These tests use keccak function and I didn't want to bring sha3 as a dependency here.

debris · 2016-08-04T13:39:35Z

blooms methods are moved to separate trait - Bloomable

tests are no longer commented

coveralls · 2016-08-04T14:05:39Z

Coverage increased (+0.2%) to 86.607% when pulling a1867a7 on move_hash into ab079fd on master.

coveralls · 2016-08-05T08:02:26Z

Coverage decreased (-0.1%) to 86.566% when pulling df29fcf on move_hash into b208331 on master.

coveralls · 2016-08-05T08:43:58Z

Coverage decreased (-0.01%) to 86.67% when pulling df29fcf on move_hash into b208331 on master.

coveralls · 2016-08-05T12:29:44Z

Coverage increased (+0.05%) to 86.75% when pulling 74c9ecb on move_hash into 725d320 on master.

rphmeier · 2016-08-05T15:01:55Z

needs a merge -- the signature_to_rsv stuff is a little less pretty than before. maybe the newtype pattern would help there.

coveralls · 2016-08-05T22:45:46Z

Coverage decreased (-0.03%) to 86.333% when pulling 88c5f55 on move_hash into e72fc53 on master.

gavofyork · 2016-08-06T18:13:48Z

util/network/src/host.rs

@@ -1150,7 +1150,7 @@ fn key_save_load() {
 #[test]
 fn host_client_url() {
 	let mut config = NetworkConfiguration::new();
-	let key = h256_from_hex("6f7b0d801bc7b5ce7bbd930b84fd0369b3eb25d09be58d64ba811091046f3aa2");
+	let key = "6f7b0d801bc7b5ce7bbd930b84fd0369b3eb25d09be58d64ba811091046f3aa2".into();


why is this a simple .into() whereas the address stuff requires a .parse().unwrap()?

gavofyork · 2016-08-06T18:16:42Z

looks good (particularly the .into() refactoring) except for the errant .parse().unwrap()s.

coveralls · 2016-08-08T09:58:04Z

Coverage decreased (-0.007%) to 86.349% when pulling 8269887 on move_hash into 4f32a9c on master.

coveralls · 2016-08-09T08:34:21Z

Coverage decreased (-0.1%) to 86.159% when pulling 974d537 on move_hash into ab8b763 on master.

debris added 6 commits July 25, 2016 20:19

moving hash.rs to bigint in progress

4dc1d42

Merge branch 'master' of github.com:ethcore/parity into move_hash

e9b3740

removed unused code from util and unnecessary dependency of FixedHash

17bfc11

Merge branch 'master' of github.com:ethcore/parity into fixed_hash_util

cad7125

Merge branch 'fixed_hash_util' into move_hash

573e775

cleaning up hash reexports

e8c451a

debris added the A0-pleasereview 🤓 Pull request needs code review. label Aug 3, 2016

tomusdrw reviewed Aug 3, 2016
View reviewed changes

debris added 2 commits August 4, 2016 08:41

Merge branch 'master' of github.com:ethcore/parity into move_hash

03c3d16

improved naming

4051524

tomusdrw reviewed Aug 4, 2016
View reviewed changes

tomusdrw added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 4, 2016

debris added 3 commits August 4, 2016 14:22

Merge branch 'master' into move_hash

efca92b

removed redundant helper methods

24c7392

bloomable trait

a1867a7

debris added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Aug 4, 2016

debris added 2 commits August 5, 2016 09:30

Merge branch 'master' of github.com:ethcore/parity into move_hash

1ed2de1

Merge branch 'split_hash' into move_hash

df29fcf

debris added 3 commits August 5, 2016 10:53

Merge branch 'master' of github.com:ethcore/parity into move_hash

316c909

Merge branch 'master' of github.com:ethcore/parity into move_hash

e796237

fixed compiling

74c9ecb

debris mentioned this pull request Aug 5, 2016

ethkey and ethstore use hash structures from bigint #1851

Merged

rphmeier added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Aug 5, 2016

Merge branch 'master' of github.com:ethcore/parity into move_hash

88c5f55

gavofyork reviewed Aug 6, 2016
View reviewed changes

gavofyork added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Aug 6, 2016

debris added 2 commits August 8, 2016 10:49

Merge branch 'master' of github.com:ethcore/parity into move_hash

e9b42d5

parse().unwrap() -> into()

8269887

debris added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Aug 8, 2016

Merge branch 'master' of github.com:ethcore/parity into move_hash

974d537

keorn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 9, 2016

debris merged commit 3b6bc97 into master Aug 9, 2016

debris deleted the move_hash branch August 9, 2016 12:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

moved hash.rs to bigint library #1827

moved hash.rs to bigint library #1827

debris commented Aug 3, 2016 •

edited

coveralls commented Aug 3, 2016 •

edited

tomusdrw Aug 3, 2016

NikVolf Aug 3, 2016

coveralls commented Aug 4, 2016 •

edited

tomusdrw Aug 4, 2016

debris Aug 4, 2016

debris commented Aug 4, 2016 •

edited

coveralls commented Aug 4, 2016 •

edited

coveralls commented Aug 5, 2016 •

edited

coveralls commented Aug 5, 2016 •

edited

coveralls commented Aug 5, 2016 •

edited

rphmeier commented Aug 5, 2016

coveralls commented Aug 5, 2016 •

edited

gavofyork Aug 6, 2016

gavofyork commented Aug 6, 2016

coveralls commented Aug 8, 2016 •

edited

coveralls commented Aug 9, 2016 •

edited

moved hash.rs to bigint library #1827

moved hash.rs to bigint library #1827

Conversation

debris commented Aug 3, 2016 • edited

coveralls commented Aug 3, 2016 • edited

tomusdrw Aug 3, 2016

Choose a reason for hiding this comment

NikVolf Aug 3, 2016

Choose a reason for hiding this comment

coveralls commented Aug 4, 2016 • edited

tomusdrw Aug 4, 2016

Choose a reason for hiding this comment

debris Aug 4, 2016

Choose a reason for hiding this comment

debris commented Aug 4, 2016 • edited

coveralls commented Aug 4, 2016 • edited

coveralls commented Aug 5, 2016 • edited

coveralls commented Aug 5, 2016 • edited

coveralls commented Aug 5, 2016 • edited

rphmeier commented Aug 5, 2016

coveralls commented Aug 5, 2016 • edited

gavofyork Aug 6, 2016

Choose a reason for hiding this comment

gavofyork commented Aug 6, 2016

coveralls commented Aug 8, 2016 • edited

coveralls commented Aug 9, 2016 • edited

debris commented Aug 3, 2016 •

edited

coveralls commented Aug 3, 2016 •

edited

coveralls commented Aug 4, 2016 •

edited

debris commented Aug 4, 2016 •

edited

coveralls commented Aug 4, 2016 •

edited

coveralls commented Aug 5, 2016 •

edited

coveralls commented Aug 5, 2016 •

edited

coveralls commented Aug 5, 2016 •

edited

coveralls commented Aug 5, 2016 •

edited

coveralls commented Aug 8, 2016 •

edited

coveralls commented Aug 9, 2016 •

edited