Split IO and network crates #1828
Conversation
| }).unwrap() | ||
| }) | ||
| .expect("Error creating worker thread")); | ||
| Worker::work_loop(stealer, channel.clone(), wait, wait_mutex.clone(), deleting) |
There was a problem hiding this comment.
It won't panic? Or is there some other way parity will be closed in case of panic in IO Worker thread?
There was a problem hiding this comment.
Set panic = "abort" in the root crate
There was a problem hiding this comment.
panic = "abort" might not be a good idea because every panic will then lead to stuff like rocksdb handles not being closed properly.
There was a problem hiding this comment.
That's fine. rocksdb and Parity are designed to be crash resistant. Removing unwinding info speeds up compilation and reduces binary size. Cargo support for this feature seems to be buggy though. Will have to revert to panic handler for now
There was a problem hiding this comment.
i suppose we will have to keep rocksdb WAL on, though.
tomusdrw
added
A5-grumble 🔥
arkpar
added
A0-pleasereview 🤓
arkpar
force-pushed
the
net-split
branch
2 times, most recently
from
5a270a2
to
e26097e
Compare
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
|
lgtm, no new logic here except for some error and structs mapping |
No description provided.