This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
protect unsafety in plainhasher; get more unique hashes #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -543,27 +543,37 @@ impl_hash!(H2048, 256); | |||
| // Specialized HashMap and HashSet | |||
|
|
|||
| /// Hasher that just takes 8 bytes of the provided value. | |||
| pub struct PlainHasher(u64); | |||
| /// May only be used for keys which are 32 bytes. | |||
| pub struct PlainHasher { | |||
There was a problem hiding this comment.
maybe should be #[repr(C)] but probably doesn't have to be.
|
Changes Unknown when pulling 03b009f on plain_hasher into * on master*. |
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does a little more work but not too much