This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Update cache usage on commiting block info #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| for hash in pending_write_txs.keys() { | ||
| self.note_used(CacheID::TransactionAddresses(hash.clone())); | ||
| } |
There was a problem hiding this comment.
each call to note_used is acquiring a write lock on the cache manager. we could improve throughput here by acquiring it once before all of the updates.
There was a problem hiding this comment.
@debris is working on that
rphmeier
added
A8-looksgood 🦄
|
LGTM, but we should prepare a PR to get rid of |
arkpar
added a commit
that referenced
this pull request
Aug 9, 2016
arkpar
added a commit
that referenced
this pull request
Aug 9, 2016
* Sync to peers with confirmed fork block only (#1863) * Fixing gas conversion * Validating u256->usize conversion * Update cache usage on commiting block info (#1871) * Use UntrustedRlp for block verification (#1872) * take snapshot at specified block and slightly better informants (#1873) * prettier informant for snapshot creation * allow taking snapshot at a given block * minor tweaks * elaborate on cli * Send new block hashes to all peers (#1875) * Reduce max open files (#1876) * ws-rs update * Fixing test * Fixing miner deadlock (#1885)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.