Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

RPC for importing geth keys #1916

Merged
merged 7 commits into from Aug 11, 2016
Merged

RPC for importing geth keys #1916

merged 7 commits into from Aug 11, 2016

Conversation

gavofyork
Copy link
Contributor

@gavofyork gavofyork commented Aug 11, 2016

Closes #1906
Depends on #1914

Two RPCs:

  • personal_listGethAccounts () returns [account0, account1, ...] for each key found in the Geth key store.
  • personal_importGethAccounts ([account0, account1, ...]) returns [imported0, imported1, ...] will import each given account into the Parity key store.

Importing Geth keys now done either through an explicit CLI option --import-geth-keys or through the on-ramping in the UI.

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Aug 11, 2016
@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage decreased (-0.2%) to 85.898% when pulling 5ebf668 on rpc-import-geth-keys into 07844d6 on master.

@@ -19,7 +19,7 @@ use docopt::Docopt;

pub const USAGE: &'static str = r#"
Parity. Ethereum Client.
By Wood/Paronyan/Kotewicz/Drwięga/Volf.
By Wood/Paronyan/Kotewicz/Drwięga/Volf/.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

@arkpar
Copy link
Collaborator

arkpar commented Aug 11, 2016

import-geth-keys should be a CLI command that does the import and exits

@arkpar arkpar added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 11, 2016
@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage decreased (-0.2%) to 85.955% when pulling 5b6e5ba on rpc-import-geth-keys into 07844d6 on master.

@gavofyork
Copy link
Contributor Author

gavofyork commented Aug 11, 2016

yeah i agree - i'll put it as a new issue: #1918

@gavofyork gavofyork merged commit ca54b8e into master Aug 11, 2016
@gavofyork gavofyork deleted the rpc-import-geth-keys branch August 11, 2016 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants