Add a few tests for the snapshot service #2059

rphmeier · 2016-09-08T10:57:31Z

Also removes the client_db field from it as that's been superseded by the DatabaseRestore trait.

coveralls · 2016-09-08T11:38:55Z

Coverage increased (+0.8%) to 84.933% when pulling bcd9639 on snap_service_tests into 012a1f3 on master.

NikVolf · 2016-09-09T12:33:43Z

ethcore/src/snapshot/tests/service.rs

+}
+
+#[test]
+fn guards_delete_folders() {


what is the test about btw?
is the name right?

it's checking if the Guard struct in the snapshot service implementation is properly deleting the restoration folder on snapshot abort or drop.

rphmeier added 5 commits September 7, 2016 19:38

remove client_db field from snapshot service

b0f6bf2

add restored_is_equivalent test

c65a5c8

test folder-deleting guards

756b7a3

also test abort_restore

ff17174

Merge github.com:ethcore/parity into snapshot_tests

bcd9639

rphmeier added the A0-pleasereview 🤓 Pull request needs code review. label Sep 8, 2016

NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 9, 2016

NikVolf reviewed Sep 9, 2016
View reviewed changes

rphmeier merged commit 835460a into master Sep 11, 2016

arkpar deleted the snap_service_tests branch October 3, 2016 15:35

Provide feedback