This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Misc small UI fixes (recently broken) #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
derhuerst
reviewed
Sep 15, 2016
| .filter((token) => token.value.gt(0)) | ||
| .map((balance, idx) => { | ||
| const token = balance.token; | ||
| const isEth = idx === 0; |
There was a problem hiding this comment.
😕 Isn't there a more robust way?
There was a problem hiding this comment.
Well, yes, find(). However the way it is setup is that ETH is always in the first position. It needs to show up first where displayed. If we move away from having it in a fixed position, then display also becomes a sorting issue. So order is -
- position 0: ETH (native network balance)
- position 1..n: Tokens
derhuerst
reviewed
Sep 15, 2016
| @@ -86,12 +85,12 @@ class Transfer extends Component { | |||
| render () { | |||
| const { stage, extras } = this.state; | |||
|
|
|||
| // title={ this.renderAccount() } | |||
There was a problem hiding this comment.
Not yet. It may need to come back since it is the account in the header - not quite sure yet if the icon on the button only is sufficient.
derhuerst
reviewed
Sep 15, 2016
| @@ -501,7 +501,7 @@ class Transfer extends Component { | |||
| const { gas, gasPrice, tag, valueAll, isEth } = this.state; | |||
| const gasTotal = new BigNumber(gasPrice || 0).mul(new BigNumber(gas || 0)); | |||
| const balance_ = balance.tokens.find((b) => tag === b.token.tag); | |||
| const availableEth = new BigNumber(balance_.value); | |||
| const availableEth = new BigNumber(balance.tokens[0].value); | |||
There was a problem hiding this comment.
Like #r79015673: Is there a more robust way?
# Conflicts: # js/src/ui/IdentityIcon/identityIcon.js
* js: (40 commits) Added docs check for existence of deprecated ethash file before attempting delete (#2103) check response.ok, throw Error array for classlist .map -> .forEach fix wording rename fundAccount to shapeshift use shapeshift ison & name fix typo Import summary removed etherscan logo, doesn't belong in this branch slightly more presentable UI... fix PropTypes as received pass correct result through to callback busy shifting flag treat coin changes properly update coin message slightly remove debug for no coins available 3 decimal places, display is unwieldly remove testing price info as well ...
* jg-etherscan-logo: Added docs fix grumble Import summary transaction list powered by
tomusdrw
added
A8-looksgood 🦄
tomusdrw
approved these changes
Sep 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of small (mostly) one-liners for where issues have recently cropped up -