registry dapp: manage records #2323
Conversation
`state.hasAccount` was missing.
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
derhuerst
added
A3-inprogress ⏳
|
You can test with this address - 0x2b63aB9b01072328E45F6eC19f301FB4aAb56748 If you are happy (that is the latest contract), we can remove the hardcoded address and do it properly with a Parity PR. |
|
Setting an
|
derhuerst
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
* js: (228 commits) registration in place Backports to master (#2530) lookup hash ethcore_hashContent call single input for commit/filename basic githubhint layout Handle reorganizations in the state cache (#2490) terminate after 30 seconds (#2513) allow updates of the secure token Using pending block only if not old (#2514) Caching optimizations (#2505) rework connection display basic test for manual token Fixed overflow panic in handshake_panic (#2495) Trim password from file (#2503) Fixing RPC Filter conversion to EthFilter (#2500) init token updates take place initial token connection - WIP Fixing error message for transactions (#2496) Adjustable stack size for EVM (#2483) ... # Conflicts: # js/src/dapps/registry/Application/application.js # js/src/dapps/registry/Container.js # js/src/dapps/registry/actions.js # js/src/dapps/registry/reducers.js
jacogr
removed
the
A7-looksgoodcantmerge 🙄
|
Applied all the needed fixes to get this back to operational. Including code cleanups, not using class functions like normal functions (there is a reason they are part of the class), fixing registering using sha3 values when it should just pass through, not using components from the main app (dapps are seperate), properly displaying the events using tables so the alignment is done properly, some of the ugly linting issues, etc. |
This PR addresses #2190.
I didn't test if a correct transaction is being sent due to ethcore/contracts#df32dce not having been deployed yet. I was lazy :P