Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

IPC-library dependency fork & bump for beta #2455

Merged
merged 2 commits into from Oct 4, 2016
Merged

IPC-library dependency fork & bump for beta #2455

merged 2 commits into from Oct 4, 2016

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Oct 4, 2016

@NikVolf NikVolf added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). B0-patch labels Oct 4, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Oct 4, 2016 •
edited

This kind of PR isn't "insubstantial" IMO, since it actually consists of whatever changes were made to the upstream library and presumably haven't been reviewed.

Here's the commit we're merging in:
paritytech/json-ipc-server@c188ea9

could you explain the motivation for this change?

@NikVolf
Copy link
Contributor Author

NikVolf commented Oct 4, 2016 •
edited

@rphmeier
just replaced that ByteBuf with Vec, since it was not used as proper buffer anyway

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Oct 4, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 87.273% when pulling 90e2d5d on ipc-issue into df4d980 on beta.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 87.276% when pulling aab816b on ipc-issue into df4d980 on beta.

@arkpar arkpar merged commit b228dc7 into beta Oct 4, 2016
@gavofyork gavofyork deleted the ipc-issue branch November 3, 2016 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NikVolf @rphmeier @coveralls @arkpar