This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Next nonce RPC #2917
Merged
Next nonce RPC #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Oct 27, 2016
|
|
||
| Ok(miner.last_nonce(&address) | ||
| .map(|n| n + 1.into()) | ||
| .unwrap_or_else(|| client.latest_nonce(&address)) |
There was a problem hiding this comment.
isn't it latest_nonce + 1?
There was a problem hiding this comment.
latest_nonce in client is actually returning the a nonce for next transaction (i.e. it returns 0x0 when there are no transactions yet)
miner.last_nonce returns last nonce of transactions transaction queue so we need to add one before returning.
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2916
Related #2908