This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add mac installer files #2995
Merged
Add mac installer files #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-pleasereview 🤓
debris
reviewed
Oct 30, 2016
| <true/> | ||
| <key>StandardErrorPath</key> | ||
| <string>/var/log/parity.log</string> | ||
| </dict> |
There was a problem hiding this comment.
should we also add --warp and --sync to homebrew plist?
https://github.com/ethcore/homebrew-ethcore/blob/master/parity.rb#L33
arkpar
reviewed
Oct 30, 2016
| <key>GID</key> | ||
| <integer>80</integer> | ||
| <key>PATH</key> | ||
| <string>/Users/gav/Core/parity/mac/Parity Ethereum.webloc</string> |
There was a problem hiding this comment.
Seems to be machine specific. A few other places like this below
Merged
|
@General-Beck would also be good to populate the |
|
Changes Unknown when pulling 9b32f91 on mac-installer into * on master*. |
|
gitlab build issue fixed in #3014 |
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be nice to allow the GUI to configure the wake-up parameters for the backend, too. e.g. to hibernate it (syncing off), to move to dark (syncing on only when UI open), passive (syncing turned on regularly) or active (syncing on). See #3002 for this.
@General-Beck It would also be good to have this building from within the CI - will need to use
packagesbuildas described in the Packages docs.