Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

execute contract function: validate address #3013

Merged
merged 3 commits into from Oct 31, 2016
Merged

execute contract function: validate address #3013

merged 3 commits into from Oct 31, 2016

Conversation

derhuerst
Copy link
Contributor

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. M6-ui labels Oct 31, 2016
@derhuerst derhuerst mentioned this pull request Oct 31, 2016
Closed
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 31, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 031fb52 on execute-contract-invalid-address into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 031fb52 on execute-contract-invalid-address into * on master*.

@derhuerst
Copy link
Contributor Author

Build failure doesn't seem to be related, UI tests ran.

jacogr
jacogr reviewed Oct 31, 2016
View reviewed changes
js/src/modals/ExecuteContract/executeContract.js
@@ -173,6 +174,9 @@ export default class ExecuteContract extends Component {
let valueError;

switch (input.kind.type) {
case 'address':
valueError = validateAddress(_value).addressError;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to set value as well....

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Oct 31, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Oct 31, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d6a6638 on execute-contract-invalid-address into * on master*.

@jacogr jacogr merged commit 55cdc7c into master Oct 31, 2016
@jacogr jacogr deleted the execute-contract-invalid-address branch October 31, 2016 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derhuerst @coveralls @jacogr