This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Mode improvements for UI #3109
Merged
Mode improvements for UI #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-inprogress ⏳
rphmeier
reviewed
Nov 4, 2016
| is active. | ||
| off - Parity never syncs at all (default: {flag_mode}). | ||
| dark - Parity syncs only when the RPC is active. | ||
| offline - Parity doesn't sync. (default: {flag_mode}). |
There was a problem hiding this comment.
auto not mentioned here, but is set as the default
arkpar
reviewed
Nov 4, 2016
| @@ -67,11 +85,28 @@ impl Visitor for UserDefaultsVisitor { | |||
| let fat_db: Value = map.remove("fat_db".into()).unwrap_or_else(|| Value::Bool(false)); | |||
| let fat_db = try!(fat_db.as_bool().ok_or_else(|| Error::custom("invalid fat_db value"))); | |||
|
|
|||
| let mode: Value = map.remove("mode".into()).unwrap_or_else(|| Value::String("active".to_owned())); | |||
| let mode = match try!(mode.as_str().ok_or_else(|| Error::custom("invalid mode value"))) { | |||
| "off" => Mode::Off, | |||
gavofyork
added
A0-pleasereview 🤓
[ci:skip]
arkpar
added
A8-looksgood 🦄
rphmeier
reviewed
Nov 4, 2016
| "off" => Ok(Mode::Off), | ||
| _ => Err(format!("{}: Invalid address for --mode. Must be one of active, passive or dark.", s)), | ||
| "offline" => Ok(Mode::Off), | ||
| _ => Err(format!("{}: Invalid value for --mode. Must be one of active, passive or dark.", s)), |
arkpar
added
A3-inprogress ⏳
rphmeier
reviewed
Nov 4, 2016
| *mode = mode.clone().into(); | ||
| match *self.on_mode_change.lock() { | ||
| Some(ref mut f) => f(&*mode), | ||
| _ => {} |
gavofyork
added
A0-pleasereview 🤓
arkpar
reviewed
Nov 4, 2016
|
|
||
| chown $USER $HOME/.parity $HOME/Library/LaunchAgents $HOME/Library/LaunchAgents/io.parity.ethereum.plist | ||
| mkdir -p $HOME/.parity/906a34e69aec8c0d | ||
| echo -n '{"fat_db":false,"mode":"passive","pruning":"archive","tracing":false}' > $HOME/.parity/906a34e69aec8c0d/user_defaults |
There was a problem hiding this comment.
"pruning":"archive"? That's harsh.
arkpar
added
A4-gotissues 💥
|
Changes Unknown when pulling 2024c05 on off-mode into * on master*. |
|
Changes Unknown when pulling 2024c05 on off-mode into * on master*. |
|
Changes Unknown when pulling 2024c05 on off-mode into * on master*. |
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Nov 5, 2016
* `--mode=off` now works. * Add Mode::Off as a persistent CLI option. * "last" not "auto" as default. * Commit accidentally unsaved file. * Whitespace [ci:skip] * Mode CLI parse fix * or offline * Save mode when it gets changed. * Fix Offline mode * Fix up mode operations. * Make passive default, but not overriding. * Fix test * Maybe not everyone wants to run an archive node...
gavofyork
pushed a commit
that referenced
this pull request
Nov 5, 2016
* Mode improvements for UI (#3109) * `--mode=off` now works. * Add Mode::Off as a persistent CLI option. * "last" not "auto" as default. * Commit accidentally unsaved file. * Whitespace [ci:skip] * Mode CLI parse fix * or offline * Save mode when it gets changed. * Fix Offline mode * Fix up mode operations. * Make passive default, but not overriding. * Fix test * Maybe not everyone wants to run an archive node... * Parity configuration settings, i.e. mode (#3212) * Add initial page * Add parity icon * opacity for parity icon * Mode selector * Actually set mode when value changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #3049.