LES Part 1 #3322
LES Part 1 #3322
Conversation
rphmeier
added
A0-pleasereview 🤓
| } | ||
|
|
||
| // Handle a request for block bodies. | ||
| fn get_block_bodies(&self, peer: &PeerId, io: &NetworkContext, data: UntrustedRlp) -> Result<(), Error> { |
There was a problem hiding this comment.
lots of duplicated code here from get_block_headers -- I stopped implementing request handlers here for the moment as I realized there is probably a decent opportunity for abstraction.
These parts are common to basically every request handler:
- check if peer exists
- deserialize request UntrustedRlp -> (req_id, T)
- check cost: &T -> U256
- request from provider: T -> U
- actual cost: &U -> U256
- response: (req_id, U) -> (packet, Vec<u8>)
So it ought to be possible to build some kind of request-handler builder with a fluent API that handles all of the common parts. This will be included in the next PR, which should encompass
- All request handlers
- Event listeners
- provider implementation for client
- ...and maybe a bit more if it'll fit.
|
No idea why travis is failing -- I didn't fiddle with the subproject commit or anything like that |
| impl Client { | ||
| /// Import a header as rlp-encoded bytes. | ||
| pub fn import_header(&self, bytes: Bytes) -> Result<H256, BlockImportError> { | ||
| let header = ::rlp::decode(&bytes); |
There was a problem hiding this comment.
Is the RLP guaranteed to be valid here?
There was a problem hiding this comment.
no, it will be addressed when the light Client struct is fully fleshed out.
| }; | ||
|
|
||
| let amount: U256 = amount.into(); | ||
| cost.0 + (amount * cost.1) |
There was a problem hiding this comment.
Is it guaranteed to not overflow?
There was a problem hiding this comment.
hmm, I suppose not. but with any reasonable cost table I think you would have a very hard time downloading a packet containing enough requests to overflow a 256-bit int
There was a problem hiding this comment.
helper functions for determining the maximum number of a given type of request which can be made will definitely be useful in the future, particularly for ranking peers.
| /// Network ID structure. | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| #[repr(u32)] | ||
| pub enum NetworkId { |
There was a problem hiding this comment.
What is this used for? What about other values?
There was a problem hiding this comment.
It's used in the handshake, only the two values are valid per the specification but more could be added in the future. I figured an enum would convey the semantics of a limited value space properly.
arkpar
added
A8-looksgood 🦄
gavofyork
added
the
B7-releasenotes 📜
gavofyork
removed
the
B7-releasenotes 📜
Protocol handler, framework for responding to and making requests.
Introduces the
ethcore-lightcrate which is currently dead code and unlinked.The vision is that
T: BlockChainClient + ?Sizedwill implement Provider.Then a
LightSyncservice will handle aLightClient, aLightProtocol, and aNetworkManagerwith listeners for key events.RPC Requests will access the shared
LightProtocolobject and make requests with callbacks.