Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Load external, builtin & local apps in parallel #3340

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Load external, builtin & local apps in parallel #3340

merged 2 commits into from
Nov 11, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 10, 2016

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M6-ui A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 10, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 10, 2016

I asked @chevdor to test, he reports that loading times are now back to normal.

ngotchac
ngotchac reviewed Nov 10, 2016
View reviewed changes
js/src/views/Dapps/dappsStore.js

_writeExternalApps () {
try {
localStorage.setItem(LS_KEY_EXTERNAL, JSON.stringify(this.externalApps));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the store package that is installed ?

Copy link
Contributor Author

@jacogr jacogr Nov 10, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have an issue logged to rework the localStorage - I prefer to do it properly everywhere and set the standard to doing it piecemeal and forgetting about the rest. (So basically when creating the MobX store didn't attempt re-invent the code that was there. Neither will I do so in this PR - it is focussed on solving the issue linked.)

Actually if we did that when we introduced the package, it would be known, now with 2 different approaches there are inconsistencies in the codebase.

@gavofyork
Copy link
Contributor

gitlab fails js tests

@gavofyork gavofyork added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 11, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Nov 11, 2016

Master merged in, tests now updated & passing.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Nov 11, 2016
@gavofyork gavofyork merged commit 80606cd into master Nov 11, 2016
@gavofyork gavofyork deleted the jg-dapps-parallel branch November 11, 2016 15:53
arkpar pushed a commit that referenced this pull request Nov 15, 2016
@jacogr @arkpar
Load external, builtin & local apps in parallel (#3340)
c19af31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ngotchac ngotchac ngotchac left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacogr @gavofyork @ngotchac