Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make sure Token is ECR20 #3347

Merged
merged 2 commits into from
Nov 10, 2016
Merged

Make sure Token is ECR20 #3347

merged 2 commits into from
Nov 10, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Nov 10, 2016

Closes #3320

Check that the token to register actually has a total supply greater than 0.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M6-ui labels Nov 10, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 10, 2016

totalSupply > 0 (so description slightly off, but apart from that looks spot-on)

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Nov 10, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 10, 2016

Merge in master for the test fix.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. B0-patch and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Nov 10, 2016
@gavofyork gavofyork merged commit eb56b82 into master Nov 10, 2016
@gavofyork gavofyork deleted the ng-tokenreg-check-ecr20 branch November 10, 2016 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants