Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Clarify error message about disabled Signer #3359

Merged
merged 1 commit into from Nov 11, 2016
Merged

Clarify error message about disabled Signer #3359

merged 1 commit into from Nov 11, 2016

Conversation

celeduc
Copy link
Contributor

@celeduc celeduc commented Nov 11, 2016

Text as written seems to indicate that Signer was re-enabled, not that it needs to be re-enabled.

(Sure would be nice to how to do that.)

@celeduc
Clarify error message to indicate
83d3703 
Indicate that Signer *needs* to be re-enabled, not that it *was* re-enabled.
@parity-cla-bot
Copy link

It looks like @celeduc hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Ethcore CLA Bot

@GitCop
Copy link

GitCop commented Nov 11, 2016

There were the following issues with your Pull Request

  • Commit: 83d3703
    • Your commit message body contains a line that is longer than 72 characters

Guidelines are available at https://github.com/ethcore/parity

This message was auto-generated by https://gitcop.com

@celeduc
Copy link
Contributor Author

celeduc commented Nov 11, 2016

[clabot:check]

@parity-cla-bot
Copy link

It looks like @celeduc signed our Contributor License Agreement. 👍

Many thanks,

Ethcore CLA Bot

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels Nov 11, 2016
@gavofyork gavofyork merged commit 7cc88b1 into openethereum:master Nov 11, 2016
@celeduc celeduc deleted the patch-1 branch November 11, 2016 14:14
arkpar pushed a commit that referenced this pull request Nov 15, 2016
@celeduc @arkpar
Clarify error message to indicate (#3359)
1b3a9ba 
Indicate that Signer *needs* to be re-enabled, not that it *was* re-enabled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@celeduc @parity-cla-bot @GitCop @gavofyork