This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Wallet files shouldn't give away the address #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Actually wallet files shouldn't contain it either, but we'll leave that for a later PR).
gavofyork
added
A0-pleasereview 🤓
gavofyork
changed the title
|
How does this fix the mentioned issue? What would be the imported account name? |
|
Why shouldn't they? Can sensitive information be derived from the UUID? |
|
the original issue related to our default naming of imported wallets; they were named after the UUID rather than their address. UUIDs are very obscure and shouldn't ever have been brought in to user-visible records (mea culpa). this fixes it. |
|
@gavofyork But you are adding the UUID to the file name in this PR. How does that prevent it from being displayed in the UI? |
arkpar
added
A5-grumble 🔥
gavofyork
changed the title
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This immediately de-anonymises the JSON file and should never have gone in. Eventually we'll want to anonymise the files completely through storing the addresses encrypted, but that can come later.