This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Don't auto-unsubscribe when subscriber callback throws #3401

Merged

gavofyork merged 1 commit into master from jg-subscription-errors

Nov 12, 2016

Contributor

jacogr commented Nov 12, 2016

Closes https://github.com/ethcore/parity/issues/3374
Unsubscribing mid-stream has several unintended consequences e.g. auto-updates stop working (balances not updating, events not showing)
UI should be clean of errors, but mistakes do happen and this stops future successful updates

(EDIT: Unable to find jsapi Module, this is not UI related but rather on the API layer affecting all users)


          Don't unsubscribe when subscriber callback throws

d2ecc33

jacogr added A0-pleasereview 🤓 M6-rpcapi 📣 labels

gavofyork added A8-looksgood 🦄 and removed A0-pleasereview 🤓 labels

gavofyork merged commit c57738b into master

gavofyork deleted the jg-subscription-errors branch

November 12, 2016 21:26

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.