Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Enable Panic=abort #3423

Merged
merged 6 commits into from
Dec 8, 2016
Merged

Enable Panic=abort #3423

merged 6 commits into from
Dec 8, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Nov 14, 2016

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. F2-build A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 14, 2016
@gavofyork gavofyork added M0-build 🏗 Building and build system. and removed F2-build labels Nov 14, 2016
@arkpar arkpar force-pushed the panic-abort branch 3 times, most recently from 0093d8b to fc3aa82 Compare November 14, 2016 16:08
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ca4fc3e on panic-abort into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3cd00da on panic-abort into * on master*.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.981% when pulling 962b7aa on panic-abort into 18f5703 on master.

@coveralls
Copy link

coveralls commented Nov 16, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 85.981% when pulling 9932b18 on panic-abort into 18f5703 on master.

@coveralls
Copy link

coveralls commented Nov 28, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 85.989% when pulling c3d2c52 on panic-abort into a7037f8 on master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 31d0d4f on panic-abort into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d652784 on panic-abort into ** on master**.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 85.893% when pulling ed4360c on panic-abort into 8972635 on master.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 7, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Dec 7, 2016

perf gains/binary size difference?

@arkpar
Copy link
Collaborator Author

arkpar commented Dec 7, 2016 •
edited
Loading

Binary is 2 megabytes smaller. Compilation 5% faster.

@rphmeier
Copy link
Contributor

rphmeier commented Dec 7, 2016 •
edited
Loading

Sounds good. Hope it all works :)

Out of curiousity, will this make it harder for users to report panics when they do happen, now that there's no unwind? Are there any backtraces/panic message?

@arkpar
Copy link
Collaborator Author

arkpar commented Dec 7, 2016

No, stack backtrace and panic message is still there.

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 7, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Dec 7, 2016

relnotes for this one?

@arkpar
Copy link
Collaborator Author

arkpar commented Dec 7, 2016

Don't think it affects users in any way

@arkpar arkpar merged commit 15ec637 into master Dec 8, 2016
@arkpar arkpar deleted the panic-abort branch December 8, 2016 10:32
@sorpaas sorpaas mentioned this pull request Jun 26, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arkpar @coveralls @rphmeier @gavofyork