Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Enhanced MethodDecoding in Transactions list #3454

Merged
merged 6 commits into from Nov 16, 2016
Merged

Enhanced MethodDecoding in Transactions list #3454

merged 6 commits into from Nov 16, 2016

Conversation

ngotchac
Copy link
Contributor

Fixes #3452 and closes #3434

Don't show empty parameters on method and display ASCII text when
sent in a transaction input.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Nov 15, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.025% when pulling 3feab57 on ng-method-decoding into 039bd3c on master.

@jacogr jacogr added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 15, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 15, 2016

@ngotchac Just update for conflicts.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Nov 15, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 86.016% when pulling 07038b9 on ng-method-decoding into 6efdc08 on master.

@ngotchac ngotchac added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 16, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 16, 2016

UX issues as discussed.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 16, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 85.952% when pulling 526629c on ng-method-decoding into 6efdc08 on master.

@ngotchac ngotchac added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 16, 2016
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 16, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 16, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.991% when pulling e848bd8 on ng-method-decoding into 2595034 on master.

@jacogr jacogr merged commit 18f5703 into master Nov 16, 2016
@jacogr jacogr deleted the ng-method-decoding branch November 16, 2016 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
3 participants
@ngotchac @coveralls @jacogr