This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Handle Signer Rejection #3476
Merged
Handle Signer Rejection #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Nov 16, 2016
| @@ -18,6 +18,7 @@ import { keccak_256 } from 'js-sha3'; // eslint-disable-line camelcase | |||
|
|
|||
| import { Logging } from '../../subscriptions'; | |||
| import JsonRpcBase from '../jsonRpcBase'; | |||
| import TransportError from '../error'; | |||
There was a problem hiding this comment.
Any reason why this is only introduced to the WS transport and not the HTTP transport (as used by dapps) as well?
There was a problem hiding this comment.
I swear... I'm going blind.
jacogr
added
A4-gotissues 💥
|
Played, looking good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3153
This also introduces real Errors with the code and type from Core