This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Keep track of block gasLimit #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
reviewed
Nov 18, 2016
| this._api.eth | ||
| .getBlockByNumber(blockNumber) | ||
| .then((block) => { | ||
| this._store.dispatch(statusCollection({ gasLimit: block.gasLimit })); |
There was a problem hiding this comment.
Should we store any other informations back from this request ? I know we are fetching timestamps for transactions from the blockNumber, we might want to store it.. Or not... It should take only 50kB of memory for one day of data, might be worth it
There was a problem hiding this comment.
I was thinking the same. However I would rather not store for the sake of storing - so rather when we have a need for it, come and extract it as opposed to extract it and look for a use at some point down the line.
ngotchac
added
A0-pleasereview 🤓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ngotchac Please take a look, this should fit in with the optimisation approach you are taking, if not need to tweak this PR